Martin Peřina has posted comments on this change.

Change subject: aaa: Remove userId parameter from LogoutUserCommand
......................................................................


Patch Set 1:

> in this solution, can the gwt use LogoutSessionCommand with different session
> id or only the restapi as it constructs something?
> 
> your last solution seems ok.
> 
> thanks!

Both GWT and REST API set sessionId for LogoutSessionCommand parameters. REST
API do this in RestApiSessionMgmtFilter. GWT do this in
GenericApiGWTServiceImpl, where setSessionId() is called on each command
parameter instance, so it practically overwrites any existing sessionId with
the correct one.

-- 
To view, visit https://gerrit.ovirt.org/38403
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia33c7dfd908c68ac06b717c0452e3de4564f35a7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to