Tomer Saban has posted comments on this change. Change subject: webadmin: Added place holder for watchdog model. ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/36688/9/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 876: Line 877: private final Map<TabName, DialogTab> tabMap = new HashMap<TabName, DialogTab>(); Line 878: Line 879: @SuppressWarnings({ "unchecked", "rawtypes" }) Line 880: public AbstractVmPopupWidget(final CommonApplicationConstants constants, > same constants is used inside an anonymous class and there for it has to be declared as final. Otherwise, It fails compilation. Line 881: CommonApplicationResources resources, Line 882: final CommonApplicationMessages messages, Line 883: CommonApplicationTemplates applicationTemplates, Line 884: EventBus eventBus) { -- To view, visit http://gerrit.ovirt.org/36688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice4111935a0ec3bb29237660702e536adbc34d14 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
