Lior Vernia has posted comments on this change. Change subject: webadmin: update "Edit network" flow with new mangement network logic ......................................................................
Patch Set 17: (2 comments) http://gerrit.ovirt.org/#/c/37026/17/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3949: Line 3950: Frontend.getInstance().runQuery(VdcQueryType.GetSupportedCpuList, new GetSupportedCpuListParameters(cpuName), aQuery); Line 3951: } Line 3952: Line 3953: private static class BooleanAsyncConverter implements IAsyncConverter<Boolean> { Have we decided that this isn't any better than AsIsConverter? Line 3954: @Override Line 3955: public Boolean Convert(Object source, AsyncQuery _asyncQuery) { Line 3956: return (Boolean) source; Line 3957: } http://gerrit.ovirt.org/#/c/37026/17/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java: Line 153 Line 154 Line 155 Line 156 Line 157 The changes in this file aren't needed anymore, another patch was merged that performs these (as well as required related changes). -- To view, visit http://gerrit.ovirt.org/37026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If53f73518214f9ac48affa4fba74750b047e25f9 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
