Lior Vernia has posted comments on this change. Change subject: webadmin: Add managemenet network field to new/edit cluster dialog ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/37141/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java: Line 762: final Network managementNetwork = model.getManagementNetwork().getSelectedItem(); Line 763: final Guid managementNetworkId = managementNetwork == null ? null : managementNetwork.getId(); Line 764: clusterOperationParameters = new AddClusterOperationParameters(cluster, managementNetworkId); Line 765: } else { Line 766: actionType = VdcActionType.UpdateVdsGroup; > To be fixed in a separate backend patch I don't think this should be merged before it's rebased on the proper backend patch, because of the common ClusterModel the frontend changes should comprise a single patch. Line 767: clusterOperationParameters = new VdsGroupOperationParameters(cluster); Line 768: } Line 769: Frontend.getInstance().runAction( Line 770: actionType, -- To view, visit http://gerrit.ovirt.org/37141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I055babd6037f127235c349499f1545396e38333f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
