Alona Kaplan has posted comments on this change. Change subject: core: Add total RX/TX in DB and DAL ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/36468/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoTest.java: Line 15: import org.ovirt.engine.core.common.businessentities.network.VmNetworkStatistics; Line 16: import org.ovirt.engine.core.compat.Guid; Line 17: import org.ovirt.engine.core.dao.BaseDAOTestCase; Line 18: Line 19: public class VmNetworkStatisticsDaoTest extends BaseDAOTestCase { Please add tests for getting and setting the new fields with null and non-null values. (Seems that it should be part of the non-existing NetworkStatisticsDaoTest, so please create a test class and at least add these tests). Line 20: private static final Guid INTERFACE_ID = new Guid("e2817b12-f873-4046-b0da-0098293c14fd"); Line 21: private static final Guid NEW_INTERFACE_ID = new Guid("14550e82-1e1f-47b5-ae41-b009348dabfa"); Line 22: private static final Guid VM_ID = new Guid("77296e00-0cad-4e5a-9299-008a7b6f4355"); Line 23: -- To view, visit http://gerrit.ovirt.org/36468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie91655cef0165375bf5e1e4f8b4d6e08275a541e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
