Eli Mesika has posted comments on this change.

Change subject: engine: Enhance brick to support storage network
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/37558/2/packaging/dbscripts/upgrade/03_06_0840_add_network_gluster_bricks.sql
File packaging/dbscripts/upgrade/03_06_0840_add_network_gluster_bricks.sql:

Line 1: ALTER TABLE gluster_volume_bricks add column network_id uuid null;
please use fn_db_add_column
Line 2: 
Line 3: ALTER TABLE ONLY gluster_volume_bricks
Line 4:     ADD CONSTRAINT fk_gluster_volume_bricks_network_id FOREIGN KEY 
(network_id) REFERENCES


Line 1: ALTER TABLE gluster_volume_bricks add column network_id uuid null;
Line 2: 
Line 3: ALTER TABLE ONLY gluster_volume_bricks
please use fn_db_add_constraint
Line 4:     ADD CONSTRAINT fk_gluster_volume_bricks_network_id FOREIGN KEY 
(network_id) REFERENCES


-- 
To view, visit http://gerrit.ovirt.org/37558
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9749febf721172a09ddce756c0eeb745a9502e1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to