Yedidyah Bar David has posted comments on this change. Change subject: core: support different exit codes ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/35632/4/src/otopi/constants.py File src/otopi/constants.py: Line 82: DIALOG_DIALECT_MACHINE = 'machine' Line 83: DIALOG_DIALECT_HUMAN = 'human' Line 84: EXIT_CODE_SUCCESS = 0 Line 85: EXIT_CODE_GENERAL_ERROR = 1 Line 86: EXIT_CODE_INITIALIZATION_ERROR = 2 Perhaps add here a comment officially setting some range for otopi's use? 0-9? Line 87: Line 88: Line 89: @util.export Line 90: @util.codegen -- To view, visit http://gerrit.ovirt.org/35632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b330bb3eaccc05798343931ff3feb70e43e0259 Gerrit-PatchSet: 4 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
