Nir Soffer has posted comments on this change.
Change subject: packaging: setup: showing the GUID instead of the physical dev
on iSCSI setup
......................................................................
Patch Set 8:
Thanks for showing the new output, it is a joy to review!
[0] - 3300000004950fc41 - 24GiB - FreeBSD - used
paths: 1 active - 0 failed
Issues:
- Using zero based lun numbers - normal people will find this strange.
If you are already doing this in the setup, keep it for consistency
for now. If not, use one-based numbers.
- The lun status (used/free) is nice touch, but it belong to the status
line where you show the paths:
[1] - 3300000004950fc41 - 24GiB - FreeBSD
used - paths: 1 active, 0 failed
This makes room for the product id in the first line:
[1] - 3300000004950fc41 - 24GiB - FreeBSD - MioLUN
status: used - paths: 1 active, 0 failed
- Most of the time, all the paths will be active, and showing "0 failed"
will not look very smart. I think if will be better to show the number
of failed luns only if there are failed luns:
[1] - 3300000004950fc41 - 24GiB - FreeBSD - MioLUN
status: used - paths: 4 active
[2] - 3300000004950fc41 - 30GiB - FreeBSD - MioLUN
status: used - paths: 3 active, 1 failed
- The indentation of the status line (\t\t) does not look good. It would
look better if the status line starts where the guid starts:
[1] - 3300000004950fc41 - 24GiB - FreeBSD - MioLUN
status: used - paths: 4 active
- Last, the - separator are not adding any value. If you are not using
this elsewhere, using two spaces will look more clean:
[1] 3300000004950fc41 24GiB FreeBSD MioLUN
status: used paths: 4 active
--
To view, visit http://gerrit.ovirt.org/37494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8cd9c02e8c753db5df6816a38317b493c9b1e7f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
