Lior Vernia has posted comments on this change. Change subject: core: Fix splitting logic for ip addresses ......................................................................
Patch Set 2: I apologize, but I don't understand the argumentation, nor the example. There is no basic need to supply another column for f(col), if col is already specified as part of the select clause. The only thing forcing it is the DISTINCT keyword, which to my understanding never belonged there (if you have duplicate entries, the problem is deeper and DISTINCT isn't the proper way to solve it). Why would I specify SELECT vms.*, vms.vm_name? -- To view, visit http://gerrit.ovirt.org/36946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923e1d99185e9aca69036edda00293ed1718b92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
