Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: allow SSO robots to fill in the login form ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37334/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java: Line 214: * when Submit is clicked. Line 215: * </p> Line 216: */ Line 217: public void fireChangeEventsOnFields() { Line 218: NativeEvent event = Document.get().createChangeEvent(); Lets try and do this within GWT, whenever I see manual DOM manipulations I start cringing. Something we can't get around it but in this case you can make a public 'fireChangeEvent' or something like that in AbstractValidatedWidgetWithLabel that does ValueChangeEvent.fire(getContentWidget(), getContentWidget().getValue()); And then here simply call userNameEditor.fireChangeEvent() and passwordEditor.firstChangeEvent(). Line 219: DomEvent.fireNativeEvent(event, userNameEditor.asValueBox()); Line 220: event = Document.get().createChangeEvent(); Line 221: DomEvent.fireNativeEvent(event, passwordEditor.asValueBox()); Line 222: } -- To view, visit http://gerrit.ovirt.org/37334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0364ac5c4524f5260480bca38642a6998d0c9147 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
