anmolbabu has posted comments on this change. Change subject: engine : Bll to pause geo-rep session ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/32667/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java: Line 21: } Line 22: Line 23: @Override Line 24: protected boolean canDoAction() { Line 25: setGlusterVolumeId(getGeoRepSession().getMasterVolumeId()); > Will the volumeId not be set in the constructor from parameters? Done Line 26: if (!super.canDoAction()) { Line 27: Line 28: return false; Line 29: } -- To view, visit http://gerrit.ovirt.org/32667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38a0ecc89fa55b607a34468075825a5604d7a59a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
