Anatoly Litovsky has posted comments on this change. Change subject: engine_page: Add validation for engine_data ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36583/1/src/engine_page.py File src/engine_page.py: Line 121: proto, Line 122: ":".join(server_url) Line 123: ) Line 124: Line 125: if cfg['server'] == 'None': cfg['server'] = "" Is it ok to continue to all the code bellow if cfg["server"] is none Line 126: if cfg['port'] == 'None': cfg['port'] = "443" Line 127: Line 128: ag = augeas.Augeas() Line 129: ag.set("/augeas/save/copy_if_rename_fails", "") Line 129: ag.set("/augeas/save/copy_if_rename_fails", "") Line 130: ag.set("/files/etc/default/ovirt/MANAGED_IFNAMES", "\"%s\"" % Line 131: ''.join(mgmtIface).encode('utf-8')) Line 132: ag.set("/files/etc/default/ovirt/OVIRT_MANAGEMENT_SERVER", "\"%s\"" % Line 133: cfg["server"]) What happens if cfg['server'] is none Line 134: ag.set("/files/etc/default/ovirt/OVIRT_MANAGEMENT_PORT", "\"%s\"" % Line 135: cfg["port"]) Line 136: Line 137: if engine_data is not None and engine_data != "": -- To view, visit http://gerrit.ovirt.org/36583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75b9c20ab4bed89509da569ee6e3de0bf4c8779f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
