Nicolas Goaziou <m...@nicolasgoaziou.fr> writes: > Rasmus <ras...@gmx.us> writes: > >> Great. The bad commit seems to be: >> >> commit 898cfbcac0560d1d742d939a62c5a8253fe9b66f >> Author: Nicolas Goaziou <m...@nicolasgoaziou.fr> >> Date: Mon Aug 10 13:34:07 2015 +0200 >> >> Implement faster `show-children' function >> >> * lisp/org.el (org-show-children): New function. >> (org-cycle-internal-local): >> (org-set-visibility-according-to-property): >> (org-content): >> (org-move-subtree-down): >> (orgstruct-setup): >> (org-show-set-visibility): >> * contrib/lisp/org-toc.el (org-toc-cycle-subtree): >> (org-toc-restore-config): >> * lisp/org-agenda.el (org-agenda-show-1): >> * lisp/org-feed.el (org-feed-update): Use new function. >> >> * etc/ORG-NEWS: Document new function. >> >> Suggested-by: Samuel Wales <samolog...@gmail.com> >> <http://permalink.gmane.org/gmane.emacs.orgmode/99616> >> >> I guess I will have to dissect it more to figure out what broke. > > `org-cycle-internal-local' calls `org-show-children', which is the Org > specific implementation of `show-children'.
OK > I don't think orgstruct details should leak into `org-show-children', so > I suggest to plug orgstruct stuff, i.e., make sure `show-children' is > called instead of `org-show-children', elsewhere. Sounds right. > One possibility is to use a hook in `org-cycle', not sure which one > though. `orgstruct-mode' could also assume its kludge status and use > something like `add-function'. This is a possibility. Isn't nadvice.el is too recent though? [Do you check NEWS files to see when something is added?]. Anyway, we can add an advice around it and redefine org-show-children or something.... Sounds ugly. Would it be enough to just change the keymap of TAB-like keys? I would love to rip orgstruct out of org.el and make it less hacky/"kludgy". The implementation remains mostly opaque to me. Rasmus -- The Kids call him Billy the Saint
