Thierry Banel <tbanelweb...@free.fr> writes: > Hi Eric, hi All > > Here is a new patch (do not apply the previous). > I added a check in the test suite for the D compiler availability > (and for the C++ compiler as well). > It silently returns true when the compiler is not found. > > To run the test suite I did that: > - start from an up-to-date org-mode/ GIT directory > - create a GIT branch, checkout there > - apply the patch : git am patch-file > - make clean > - make autoloads > - make test-dirty > > Eric, this result you were getting is strange: > FAILED ob-C/inhomogeneous_table > It is as though the NEW test suite was run against the OLD ob-C.el > Maybe there was an old .elc compiled file hanging around ? > > Anyway, it works fine for me. > Could someone check and tell me if something goes wrong ? > > Have fun > Thierry >
Hi Theirry, This new patch looks great, and the test suite passes locally. I've just applied it. Thanks! Eric also, thanks for taking the time to flesh out the commit message > > > Le 06/06/2014 18:31, Eric Schulte a écrit : >> Hi Thierry, >> >> This looks wonderful, however after applying this patch I get the >> following errors when running "make test-dirty". >> >>> 10 unexpected results: >>> FAILED ob-C/inhomogeneous_table >>> FAILED ob-D/inhomogeneous_table >>> FAILED ob-D/integer-var >>> FAILED ob-D/list-list-var >>> FAILED ob-D/list-var >>> FAILED ob-D/simple-program >>> FAILED ob-D/string-var >>> FAILED ob-D/table >>> FAILED ob-D/two-integer-var >>> FAILED ob-D/vector-var >> Could you update the test suite so that the C tests pass, and the D >> tests are not executed when D is not available? >> >> Also, could you flesh out the commit message so that it meets the Emacs >> commit message guidelines (http://orgmode.org/worg/org-contribute.html)? >> >> Many Thanks, >> Eric >> >> > > -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D (see https://u.fsf.org/yw)
