Pascal Fleury <fle...@google.com> writes: > Hello, > > Great, thanks for the guidance. I hope I managed it all correctly. >
I've applied this patch. I made a couple of minor changes in a subsequent commit (a7189aa). These were indentation and whitespace changes to enforce two coding conventions, 1. limit line lengths to <80 characters 2. remove dangling parens on lines w/o any other text and to rename one function to be specific to ob-shell.el. Thanks for contributing! > > On Fri, Apr 11, 2014 at 11:33 AM, Bastien <b...@gnu.org> wrote: > >> Hi Eric and Pascal, >> >> Eric Schulte <schulte.e...@gmail.com> writes: >> >> > Also, I think the google-wide copyright stuff is sorted out. >> >> Yes it is: we can accept patch from employees of Google, Inc. >> >> > Good :-) > > >> Pascal, I guess it's safe to assume anyone with a @google.com >> email address is a Google employee -- let me know if it's not >> the case. >> >> > Yes, I checked internally, and this is a safe assumption. > > >> Also, if you can sign your patches (git format-patch -s) that'd >> be even better, but not mandatory. >> >> > I did, also wrote the description of the patch according to the rules I > found on orgmode.org > > >> Thanks! >> >> -- >> Bastien >> > > > Best regards, > --paf > -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D
