Nicolas Goaziou writes:
> Hello,
>
> Alan Schmitt <alan.schm...@polytechnique.org> writes:
>
>> I'm not sure about the procedure to apply this patch, however. Should I
>> do it myself?
>
> You're the file maintainer, aren't you? :)
;-)
A couple notes about the patch:
- Could you create it using "git format-patch"? This way we'll have
more metadata in the commit.
- I think there is an issue with the handling of signatures. I tried
with an old letter that uses a LCO with a graphical signature in it, but
it gets overridden upon export. Here is the generated TeX.
#+BEGIN_SRC latex
\LoadLetterOption{InriaRennesFR}
\setkomavar{signature}{\usekomavar{fromname}}
#+END_SRC
It seems to come from this part of the patch:
#+BEGIN_SRC emacs-lisp
(signature (plist-get info :signature)))
(concat
;; Letter Class Option File
(when lco
(let ((lco-files (split-string lco " "))
(lco-def ""))
(dolist (lco-file lco-files lco-def)
(setq lco-def (format "%s\\LoadLetterOption{%s}\n" lco-def
lco-file)))
lco-def))
;; Define "From" data.
(when sender (format "\\setkomavar{fromname}{%s}\n" sender))
(when from-address (format "\\setkomavar{fromaddress}{%s}\n"
from-address))
(when phone-number (format "\\setkomavar{fromphone}{%s}\n" phone-number))
(when email (format "\\setkomavar{fromemail}{%s}\n" email))
(when signature (format "\\setkomavar{signature}{%s}\n" signature))))
#+END_SRC
If signature is set for some reason (and it seems to be by default),
then it will override what is in the LCO. I have not found a way to
set the options such that the signature from the LCO gets picked up.
Alan
