Morgan Smith <[email protected]> writes:
>> We already do something similar in `org-export--dispatch-action'
>> and nobody complains.
>
> I mean this bug report is someone complaining about
> `org-export--dispatch-action'. We are talking about adjusting
> `org-scroll' to fix `org-export--dispatch-action'.
(I should have re-read the bug in question, not just your email. Oops)
>>> So at least on my system, switching from "read-event" to
>>> "read-key" would fix this.
And break mouse wheel I suspect.
>>> Maybe I'm overthinking this. IDK. What do you think?
>>
>> I think we can follow the existing patterns. If those turn out
>> to be problematic, we change them everywhere. Before that, we
>> should aim for more consistent handling of menus across Org.
>
> `org-clock-resolve` uses 'read-char-exclusive' and has no way of
> scrolling the buffer
>
> `org-sparse-tree` uses `read-char-exclusive` and doesn't have a
> buffer to scroll
>
> `org-agenda' uses `read-char-exclusive` and doesn't allow
> scrolling with DEL or SPC
>
> `org-attach` uses `read-char-exclusive` and suffers from the same
> bug we are currently solving (it sets ADDITIONAL-KEYS as t but
> never gives org-scroll those keys)
>
> `org--mks-read-key` uses `read-char-exclusive` and doesn't allow
> scrolling with DEL or SPC
>
> If we follow existing patterns then we would use
> `read-char-exclusive` and not allow scrolling using DEL or SPC.
>
> Now `read-char-exclusive` is probably not a good solution as it
> eats `mouse-up`.
>
> So I think what I've learned from this exercise is there are no
> existing patterns in our menus and they kind of suck (no mouse-up
> support).
Note that export dispatch menu explicitly replaced read-char-exclusive
with read-event. That change was deliberate:
+*** Export dispatcher supports arrow keys and mouse wheel
+
+Previously, the arrow keys and the mouse wheel were ignored in the
+export dispatcher, ~org-export-dispatch~ bound to =C-c C-e=. Now,
+they scroll the text in the export dispatcher window.
Whether we want to allow scrolling in other menus is a separate
question. We might, but then there are also no complaints from
users. So, it is likely very minor improvement.
> Do you want me to just push the attached patch, close this issue,
> and walk away? That's what I'm leaning towards.
I think we can push the patch at least. Whether we want to do more - up
to you and what you think is useful to spend time on.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
