Hi, I pushed a couple of fixes onto feature/org-latex-preview. There is still an input I need from you. See below.
Karthik Chikmagalur <[email protected]> writes: >> 4. ox-html changes are vast and seemingly introduce a number of >> regression. At least, I saw some features removed on the branch >> compared to main but no alternative version is implemented on the >> branch. Handing org-html--unlabel-latex-environment is one of them, >> but I saw more yesterday and concluded that more careful review is >> needed to not miss more. > > My understanding is that org-html--unlabel-latex-environment is not > needed anymore since org-latex-preview handles equation numbering. In > particular, the equation numbers are now part of the preview images. > Formulas across the entire document/export region are handled in a > single run by org-latex-preview, so consistent numbers are assigned to > all the formulas. > > I see that org-html--unlabel-latex-environment is still present with no > uses. I can remove it if you want, or you can let me know if some other > solution is desired here. There two issues with this: 1. On the branch, you are now embedding the equation number as a part of the image, which is a different logic from what is on main. The change could be acceptable if it did not alter the appearance, but it does. In the default CSS, we have .equation-label { display: table-cell; text-align: right; vertical-align: middle; } which is user-configurable. On the branch, it is no longer the case. 2. Consider the following: #+options: tex:unknown (can also be tex:html) * This is test \begin{equation} 1 + 1 = 2 \end{equation} Previously, (t (org-html--wrap-latex-environment latex-frag info caption label)) handled equation numbering in this scenario. On the branch, the numbering is lost because caption is no longer computed. Is there any specific reason why you need to embed the numbering into LaTeX preview in html export? Maybe we can use the old logic with equation numbers added separately? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
