JV <[email protected]> writes:

> Subject: [PATCH 1/4] org: Improve org-in-block-p

Thanks for the update!
I tested it a little, and I feel that some things are not yet very
intuitive in the way the fontification is layed out.

Consider the following Org document

* This is test, yes

- foo, bar
  #+begin_center
  here
we go and do
~what~?
                      {{{macro}}}
            # comment
[cite:@foo]
#+end_center
  - bar
  - baz
   here

Then, try to set org-structure and org-list-indent face background to
something visible. You will see various deficiencies :)

> (org-find-invisible-color): Rename function since color is now used
> as background as well as foreground.

When we rename public functions, it should be accompanied with defalias
or define-obsolete-function-alias, so that we do not break working
third-party code.

Also, several nits:
1. Commit message in 4/4 does not quote symbols
2. ORG-NEWS entry should use ~code~, not =verbatim=

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to