Ihor Radchenko <[email protected]> writes:

> Daniel Mendler <[email protected]> writes:
>
>> Ihor Radchenko <[email protected]> writes:
>>> Morgan's patch only removes packages on make cleanall.
>>
>> It seems that Morgan invokes "make cleanall" too often, while "make
>> clean" would do, leaving him in a state where dependencies need to be
>> fetched again, breaking "offline mode"?
>
> How did you infer that he uses make cleanall too often?
> The question of offline mode has little to do with what we are used or
> not used to do.

This is how I read his mails, as if he commonly executes cleanall
leaving him in a state where he cannot continue offline. My assumption
was that a plain clean might be enough. I'd argue that it may make sense
to offer an action which cleans the repository as much as possible,
while still preserving downloaded dependencies.

> It is about forcing people to download code from online resources they
> do not expect.

This seems a bit artificial as argument. You also have to clone the
repository once in the beginning. The next step would then be to
download dependencies, and if desired this could require a manual
confirmation or a manual invocation of "make download-deps". I am wary
myself of code which pulls in additional code automatically.

Daniel

Reply via email to