Ihor Radchenko <[email protected]> writes: >> Attached is the tiny patch that modifies two files: >> - org.el/org-activate-links (added an overlay to links in comments). >> - org-faces.el/org-link-comment-face (added face). > > Thanks for the patch! > > Unfortunately, overlays are not the right approach to handle > fontification. The reason is twofold: (1) font-lock in Emacs is > traditionally done via text properties. All the machinery around assumes > this fact. Using overlays is sometimes acceptable, but that's rather an > exception; (2) overlays always belong to current buffer and will not > transfer to indirect buffers. So, the patch you propose will leave the > bug not fixed in all the indirect buffers. > > So, we do need to use text properties.
It has been a month. Did you have a chance to look into my comments? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
