Am I allowed to change the subject line? Does that mess things up? I want the subject to be "Rewrite 'org-clock-timestamps-change'".
Ihor Radchenko <[email protected]> writes: > Morgan Smith <[email protected]> writes: > >> >> If we want to go through all the org functions like this to make sure >> the interactive specs are correct and we aren't calling >> `prefix-numeric-value' unnecessarily, then there are probably about 15 >> functions we need to change. > > I just referred to this particular function you are changing in the > patch. It has exactly two callers that declare their interactive spec as > "raw". We can instead change those callers to pass numeric value. > Does it make sense? The issue here has nothing to do with difficulty and everything to do with scope. The commit is specifically "rewrite 'org-clock-timestamps-change'". Sneaking those two changes to other functions into that commit does not follow the rule of "one commit one change". So you are asking me to add an additional commit of fixing up the interactive spec. But now I've got a commit that is literally 2 lines which is also not good as we don't want many tiny commits in our project. This is why I've decided that in order to do what you've said requires me to go through all the interactive declarations. Well you've done it. Now I'm going through all the interactive declarations and fixing things. So can we simply approve these changes and I'll start a new thread in a bit? I mostly want to know what you think of "Add match groups to `org-element-clock-line-re'" To prove I'm working on the 'interactive' specs, here is a sneak preview: In an org agenda try using any of the following command with a prefix argument: org-agenda-day-view (bound to d) org-agenda-week-view (bound to w) org-agenda-fortnight-view org-agenda-month-view org-agenda-year-view (bound to y) That's right, you get the following message: org-agenda-change-time-span: Wrong type argument: number-or-marker-p, (4) This is due to incorrect 'interactive' specs.
