On 2026-05-22 18:28, Morgan Smith wrote: > Turns out my CI was broken. You did not break any tests.
Oh good, thanks! The warnings I could deal with, but I was struggling to see what tests it broke. > It's based on guix but it is an entire rabbit hole that seems to > break more often then I'd like. I don't mind one bit doing the > testing for you. I'd much rather you spent your time on more > fruitful endeavors like adding this feature! Neat, I think I remember Ihor saying something about keeping multiple versions [in Gentoo]. I’m glad you’re willing to run these tests, but I also don’t want to send anything breaking! > It looks like they might try to deprecate this syntax of `when-let*' > as I can see in this quote from the docstring of `if-let*' > > #+begin_quote > An older form for entries of VARLIST is also supported, where SYMBOL is > omitted, i.e. (VALUEFORM). This means the same as (_ VALUEFORM). > This form is not recommended because many Lisp programmers find it > significantly less readable. A future release of Emacs may introduce a > byte-compiler warning for uses of (VALUEFORM) in VARLIST. > #+end_quote Good to know, thanks. Once Emacs 32 is released and we stop supporting Emacs 29, we can switch it back: lisp/subr.el: >> ;; FIXME: Once Emacs 29 is ancient history we can consider a >> ;; byte-compiler warning. This is because Emacs 29 and older will warn >> ;; about unused variables with (_ VALUEFORM). On 2026-05-22 18:28, Morgan Smith wrote: > I started going down the rabbit hole of trying to rewrite it with > `seq-reduce' (which seems like a useful function but I've never > managed to find a place to use it) but I'm trying to commit to less > rabbit holes so I purposefully gave up. Definitely possible, I’m a big fan of ‘seq-reduce’. The real reason I stuck with the more basic functions is because I didn't see other ‘seq’ functions in the file, and I don’t know of a good way to look at the dependency graph to see if it’s included. > Tests pass on emacs 29, 30.2, and a recent emacs/master build. > Tests pass with TZ set to UTC, Europe/Istanbul, and America/New_York. Great, thanks Morgan! [in Gentoo]<https://wiki.gentoo.org/wiki/SLOT> Best, -- Jacob S. Gordon [email protected] Please don’t send me HTML emails or MS Office/Apple iWork documents. https://useplaintext.email/#etiquette https://www.fsf.org/campaigns/opendocument
