Ihor Radchenko <[email protected]> writes:

> Morgan Smith <[email protected]> writes:
>
>> There is no way to meaningfully and in a stable manner maintain the undo
>> history.  So I just squashed all the history together using
>> `org-with-undo-amalgamate'.
>
> +1
>
>> Subject: [PATCH 2/9] test-org/move-subtree: Factor common logic
>> Subject: [PATCH 3/9] test-org/move-subtree: Test for error more precisely
>
> Should these two patches be squashed?
> Otherwise, LGTM.

The first one is a refactoring that should not meaningfully change
anything.

The second patch modifies the behavior to test for the error right
where I expect it to be.

Strictly speaking they should be two patches but I don't know if we need
to be strict with the test suite :P.  Do you feel I'm clutter up the git
log with too many test suite commits?

Reply via email to