Lei Zhe <[email protected]> writes:
> Thanks for your comments.
>
>>1. One docstring is wider than 80 chars
>>2. Commit message should have double space between sentences.
>>3. There are some unrelated whitespace-only changes.
> All those issues should have been addressed in the new patch.
>
>>Otherwise, what is left is etc/ORG-NEWS announcement and updating the manual.
> I've also updated the News and the documentation.
>
> Please find the updated patch. Appreciate any advice.
Thanks!
Several more comments:
1. Please cleanup trailing spaces across the patch
2. in ORG-NEWS, we need to document that
org-babel-tangle-use-relative-file-links is ignored
3. org-babel-tangle-use-relative-file-links is actually not fully
ignored in the patch:
(list start-line
(if org-babel-tangle-use-relative-file-links
(file-relative-name file)
file)
link
source-name
params
(if (org-src-preserve-indentation-p) (org-trim body t)
(org-trim (org-remove-indentation body)))
comment)
(it actually looks like a bug in existing code - we compute relative
file name vs. current buffer, not vs. tangle file)
4. *** New function ~org-babel-tangle--compute-targets~
is not needed. We do not announce changes and additions to the
internal functions (with "--" in their name)
5. We are introducing a breaking change in the return value of
`org-babel-tangle-single-block'. As discussed earlier, we should
probably introduce a new optional argument ALLOW-MULTIPLE to
preserve backwards-compatibility as much as possible.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
