Morgan Smith <[email protected]> writes: > See attached many patches as I do love scope creep! As usual feel free to > apply any patches you're happy with so I don't have to keep resending them > (except patches marked WIP of course).
Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c29fe127b https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9b5a67fd5 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4bfc146bc https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f8b18e1f6 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3cdaa6c0d https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=531e8ab8f The most-positive-fixnum will sometimes overflow as it is used as argument in `+', but it will translate into bignum, so should still work. > Patch 7 actually fixes the reported bug! But don't apply that one! It's > marked WIP. Do note that there is no guarantee that an agenda item is pointing to Org mode buffer. It can point to diary. > As we transition to using the org-element API in more places, we are > eventually > going to have to figure out what to do about the agenda. My WIP patch shows > one way to get access to the org element API but I assume it comes with some > serious performance issues (still have no clue how parsing/caching works so > please let me know if my assumption is correct). Repetitive calls to org-element-at-point are cached. See `org-element--cache-hash-left' and the variables nearby. > I haven't done any investigations yet and would just like to ask: How are we > planning on shoving org-element into the agenda? Have we already done that > somewhere? https://git.sr.ht/~yantar92/org-mode/tree/feature/refactor-deps-v2/item/lisp/org-agenda-line-format.el#L529 https://git.sr.ht/~yantar92/org-mode/tree/feature/refactor-deps-v2/item/lisp/org-agenda-line-format.el#L495 -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
