Pedro Andres Aranda Gutierrez <[email protected]> writes:
>> Then, can you update the comment explaining why xeCJK is necessary?
>>
>> > Could we keep that as a FIXME for a refinement and discuss it further in
>> > the future?
Ok.
>
>> The way to define features is not the same for org-latex-fontspec-config
>> and org-latex-fontspec-default-features. Why not make
>> org-latex-fontspec-default-features support feature string?
>
> Good point. Maybe in the next iteration, we can *ADD* this possibility to
> the current settings. Please keep that FFS.
Ok.
Now, continuing the code review. Let's move on to other files.
> modified lisp/org.el
> -(defun org-splice-latex-header (tpl def-pkg pkg snippets-p &optional extra)
> +(defun org-splice-latex-header (tpl def-pkg pkg fspec snippets-p &optional
> extra)
This is a breaking change in the API function. Instead of adding a new
argument in the middle of the argument list, please add it as an
optional argument at the end. It will be the least intrusive approach.
> (defcustom org-format-latex-header "\\documentclass{article}
> \\usepackage[usenames]{color}
> -\[DEFAULT-PACKAGES]
> -\[PACKAGES]
Could you explain this change?
> - ;; amsmath and amssymb after inputenc/fontenc for pdflatex
> + ;; amsmath and amssymb after inputenc/fontenc for pdflatex ??
Could you elaborate?
> modified lisp/ox-latex.el
> +(declare-function org-list-or-null-p "org-macs.el" (object))
I think this is redundant.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
