dominic meiser <[email protected]> writes: > I encountered what appears to be an issue with noweb reference expansion > during tangling. I'm not sure if this is a known limitation, expected > behavior, or if I'm misunderstanding how it should work, but I've prepared > some patches that seem to fix the issue. > > The Problem: > When using `:noweb tangle`, nested noweb references don't get recursively > expanded. For example: > ... > Expected: The tangled output should contain "// block C content" > Actual: The tangled output contains the unexpanded reference "<<ref3>>" > ... > Before I submit this as a proper patch series, I wanted to check: > - Is this the expected behavior, or is it indeed a bug?
This does indeed look like a genuine bug. > - If it's a bug, does this approach seem reasonable? Yes. > - Are there any other considerations I should account for? Your approach look reasonable, but you also need to make sure that all the callers of `org-babel-expand-noweb-references' are updated. Also, I do not see you in FSF copyright records. Would you be interested to complete the copyright assignment, so that we can accept large contributions from you? See https://orgmode.org/worg/org-contribute.html#copyright > The patches are available on my branch: `fix-noweb-tangle-recursive-expansion` Hmm. Which git server? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
