l...@phdk.org writes: >> Applied, onto main. > Great! > >> May you elaborate on the edge cases you encountered? >> It may be a good idea to add such cases to the tests as well. > > I think they all reduced to the case where adding the spaces increased > the minimum indent of the block, in which case `org-indent-line' would > remove `block-content-ind' spaces from all other lines in the block. I > attached a patch with a simple test where I also cleaned up the use of > obsolete function `org-get-indentation' in `test-org.el'.
May you please explain how the test in the patch is related to the change you made in the code? The test seems to be passing both with and without your change. > As a final thing on this patch in particular, I thought for a second > that I might have caused a regression in modes where the > indent-function cycles indentation (e.g. python-mode). Seems like > python-mode in particular relies on `last-command' and not current > indentation so it never worked. Idk if there's a good solution to > this issue from our side. Still, I think it makes sense to at least > refrain from moving stuff around unnecessarily, just in case some > modes do rely on current indentation. What do those modes suggest for users who bind custom command for indentation? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
