Hey, folks. Like the subject line says, I'm noticing unexpected behavior when I go to a headline that's visible but doesn't show as much context as requested by org-fold-show-context-detail.
Seems to be the case that org-goto only tries to unfold if point lands on an invisible part of the buffer, but I expected org-goto to behave like org-agenda-switch-to, which unfolds regardless of whether or not point lands on invisible text. Here's a minimal example to run from a scratch buffer in emacs -Q: ``` (setq org-startup-folded 'fold org-fold-show-context-detail '((default . local)) org-goto-interface 'outline) (pop-to-buffer (with-current-buffer (get-buffer-create "test-org-goto") (erase-buffer) (insert "* my headline\n" "some content\n" "\n") (org-mode) (current-buffer))) ;;; interactively call org-goto RET ;;; expected: point on first headline AND headline contents visible ;;; actual: point on first headline, headline still folded ``` Does this seem like a bug to you? If so, I've attached a minimal patch that removes the invisibility checks within org-goto. I ran the org tests per https://orgmode.org/worg/org-contribute.html#first-patch and everything seemed fine (one test failed, but it's test-org-publish/resolve-external-link and that seems to also fail at main as of this morning). Thanks for taking a look! Trevor Murphy (he/him) ------------------------------------------------------------------------ Emacs : GNU Emacs 30.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.49, cairo version 1.18.4) Package: Org mode version 9.7.11 (release_9.7.11 @ /usr/share/emacs/30.1/lisp/org/) current state: ============== (setq org-yank-image-file-name-function 'org-yank-image-autogen-filename org-persist-before-write-hook '(org-element--cache-persist-before-write) org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate) org-persist-after-read-hook '(org-element--cache-persist-after-read) org-confirm-elisp-link-function 'yes-or-no-p org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-fold-show-all append local] 5] #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes) org-confirm-shell-link-function 'yes-or-no-p org-archive-hook '(org-attach-archive-delete-maybe) org-metaup-hook '(org-babel-load-in-session-maybe) org-occur-hook '(org-first-headline-recenter) org-bibtex-headline-format-function 'org-bibtex-headline-format-default org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link) ("id" :follow org-id-open :store org-id-store-link-maybe) ("eww" :follow org-eww-open :store org-eww-store-link) ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link) ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link :insert-description org-info-description-as-command) ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link) ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link) ("w3m" :store org-w3m-store-link) ("doi" :follow org-link-doi-open :export org-link-doi-export) ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell) ("news" :follow #[514 "\301\300\302 Q \"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"] ) ("mailto" :follow #[514 "\301\300\302 Q \"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"] ) ("https" :follow #[514 "\301\300\302 Q \"\207" ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"] ) ("http" :follow #[514 "\301\300\302 Q \"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"] ) ("ftp" :follow #[514 "\301\300\302 Q \"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL ARG)"] ) ("help" :follow org-link--open-help :store org-link--store-help) ("file" :complete org-link-complete-file) ("elisp" :follow org-link--open-elisp)) org-persist-directory "/tmp/org-persist-sQA4UO" org-cycle-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-agenda-before-write-hook '(org-agenda-add-entry-text) org-metadown-hook '(org-babel-pop-to-session-maybe) org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-sort-function 'string-collate-lessp org--warnings nil org-babel-pre-tangle-hook '(save-buffer) org-export-before-parsing-hook '(org-attach-expand-links) org-link-shell-confirm-function 'yes-or-no-p org-fold-core-isearch-open-function 'org-fold-core--isearch-reveal outline-isearch-open-invisible-function 'outline-isearch-open-invisible org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer) org-agenda-loop-over-headlines-in-active-region nil org-link-elisp-confirm-function 'yes-or-no-p org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-empty-lines org-cycle-optimize-window-after-visibility-change org-cycle-display-inline-images) org-persist-before-read-hook '(org-element--cache-persist-before-read) )
From 045175db8f0ae04dadd24f81240ca261b8e89d8f Mon Sep 17 00:00:00 2001 From: Trevor Murphy <trevor.m.mur...@gmail.com> Date: Fri, 21 Mar 2025 11:01:03 -0700 Subject: [PATCH] org-goto: Show fold context. * lisp/org-goto.el (org-goto): Always check `org-fold-show-context' after a successful goto. --- lisp/org-goto.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/org-goto.el b/lisp/org-goto.el index aaead874c..6a163a9cb 100644 --- a/lisp/org-goto.el +++ b/lisp/org-goto.el @@ -282,8 +282,7 @@ With a prefix argument, use the alternative interface: e.g., if (progn (org-mark-ring-push org-goto-start-pos) (goto-char selected-point) - (when (or (org-invisible-p) (org-invisible-p2)) - (org-fold-show-context 'org-goto))) + (org-fold-show-context 'org-goto)) (message "Quit")))) (provide 'org-goto) -- 2.49.0