Re: [PATCH] org-ctags.el: Do not activate on load

[Max Nikulin]

On 30/04/2024 19:59, Ihor Radchenko wrote:

/bin/sh: 1: Syntax error: Bad function name
(ert-test-failed
      ((should
        (test-org-ctags/list-elements-equal-p
        (list ...)
        (test-org-ctags/with-fake-ctags temp-dir "regexp" ...)
        '(2)
        "Regexp should be escaped."))
       :form
       (test-org-ctags/list-elements-equal-p
        ("--regex-orgmode=/<<([^<>]+)>>/\\1/d,definition/")
        "Sould be overwritten by org-ctags mock script"
        (2)
        "Regexp should be escaped.")
       :value nil :explanation "Shell command failed"))
FAILED   630/1311  test-org-ctags/create-tags-escape (0.003107 sec) at 
../lisp/test-org-ctags.el:132

At least error message is not bad. Dash does not like
ctags-mock() { ... }

diff --git a/testing/lisp/test-org-ctags.el b/testing/lisp/test-org-ctags.el
index 7f5fca948..b8e3e4d22 100644
--- a/testing/lisp/test-org-ctags.el
+++ b/testing/lisp/test-org-ctags.el
@@ -76,17 +76,17 @@ (defmacro test-org-ctags/with-fake-ctags
             (,dir (concat ,base "/" ,subdir))
             (,temp-file (concat ,dir "/ctags.txt"))
             (org-ctags-path-to-ctags
-             (test-org-ctags/mock-command ,temp-file "ctags-mock"))
+             (test-org-ctags/mock-command ,temp-file "ctags_mock"))
             ,buffer)
        (make-directory ,dir)
        (unwind-protect
            ;; `org-ctags' commands call `buffer-file-name'.
            (with-current-buffer
                (setq ,buffer (find-file-noselect ,temp-file))
-             (insert "Sould be overwritten by org-ctags mock script")
+             (insert "Should be overwritten by org-ctags mock script")
              (save-buffer)
              ,@body
-             (test-org-ctags/get-args ,temp-file ,base "ctags-mock\n"))
+             (test-org-ctags/get-args ,temp-file ,base "ctags_mock\n"))
          (kill-buffer ,buffer)
          (delete-file ,temp-file)
          (delete-directory ,dir)))))