Matt <m...@excalamus.com> writes: > I found cleaning the output was dramatically helped by calling > `buffer-substring-no-properties' instead of `buffer-substring' in > `org-babel-comint-async-filter'. I'm not sure why `buffer-substring' was > originally used. `make test' shows no failures, so I assume it doesn't make > a difference...?
Could you please elaborate? What was the problem with `buffer-substring'? I am asking because one of the previous versions of `org-babel-comint-wait-for-output' relied upon 'face text property. See a35d16368. > ---- On Tue, 07 Feb 2023 06:40:51 -0500 Ihor Radchenko wrote --- > > That's likely because of the same reasons why prompt did not get cleaned > > in synchronous blocks earlier. See `org-babel-comint-with-output'. > > That, my friend, was a wild ride. > > I'm curious about people's feelings on `org-babel-comint-with-output'. My feelings are: WTF and how does it even work :) More in https://yhetil.org/emacs-devel/87y1tgqhmc.fsf@localhost/ It is a mess, because comint.el is not designed for programmatic use. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
