Jack Kamm <jackk...@gmail.com> writes: > Ihor Radchenko <yanta...@posteo.net> writes: > >> Marked for future removal in ob-python.el. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=21741a469 > > Thanks Ihor. > > Not sure if it's too early for this, but I've prepared a patch to remove > the support for python-mode.el, attached.
main branch is for Org 9.7. So, removing it should happen before the next Org 9.7 release on main anyway. I have no objections on this. > Also, to help any python-mode users with the transition, I ported the > code to support python-mode to an external package here: > > https://gitlab.com/jackkamm/ob-python-mode-mode > > As always, feedback is welcome, either on this patch or the external > package. I find the need to use advise awkward. Is it necessary? > Subject: [PATCH] ob-python: Remove python-mode.el support > > * lisp/ob-python.el (org-babel-python-mode): Remove customization > variable. Let's follow the usual approach and first deprecate it. It should become a constant with 'python value in org-compat.el. Deprecating is not make sure that other packages that might be testing the variable value do not get broken. > (org-babel-python-send-string): Renamed from > org-babel-python--send-string, turning it into a public function to > accommodate ob-python-mode-mode which advises this function. Also, > remove some code for python-mode.el Note that we usually `quote' Elisp symbols in the commit messages. Otherwise, the patch looks good. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
