Max Nikulin <maniku...@gmail.com> writes: >>>> We might do something like >>>> >>>> (eval-and-compile (org-assert-version)) >>> >>> This will give obscure error during compiling since `org-assert-version' >>> is not defined. >> >> Yes, but we will at least abort the compilation this way. > > You are right that it prevents creation of .elc files. Unfortunately > `byte-recompile-directory' converts failure into a message instead of > aborting package install completely.
> When used consistently, it should cause load of Org completely > uncompiled during next Emacs session. It is better than having > incorrectly compiled files. > > Notice that `org-assert-version' works for compiled files only, so if a > user loads some third-party package (hyperbole?) that loads built-in Org > and later adds new Org to `load-path' then we get an obscure error again. I think that most reliable approach in this situation would be pulling `org-assert-version' into a dedicated new file, similar to what you suggested below. That way, we will not have feature cashes. However, I am concerned about what is going to happen if wrong org-version is defined during compilation. `org-assert-version' can then be compiled with wrong org-version value and later produce similar obscure error. Can you test such scenario using your Debian reproducer? > In addition I have noticed that e.g. org-matlab.el contains > > (require 'org-macs) > (org-assert-version) > > Shouldn't it be (eval-when-compile (require 'org-macs)) since no > functions are used from this file? Some files have duplicated (require > 'org-macs). org-macs is pulled in by Org feature dependencies anyway. So, it does not matter in practice. I also left the duplicates consciously to keep the same pattern with `org-assert-version' usage. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
