Hello,
Copying a subtree with `org-copy-subtree' in an org file with local
variables marks the buffer as modified. This is because
`org-copy-subtree' calls `org-preserve-local-variables', which deletes
local variables, executes some body, and then inserts them again, which
results in a modified buffer even if the buffer was not modified before
and the body does not modify it either, like in the case of
`org-copy-subtree'.
What would you think about a change like the following in the definition of
`org-preserve-local-variables' to solve the issue?
+ (let ((modified-before-p) (buffer-modified-p))
;; current code that deletes local variables
+ (unless modified-before-p (set-buffer-modified-p nil))
;; current code that executes body
+ (let ((modified-after-p (buffer-modified-p)))
;; current code that restores local variables
+ (unless modified-after-p (set-buffer-modified-p nil))))
Could the current code or my proposed change have any more unintended
consequences, for example in the undo tree or mark ring? Sometimes when
I undo or jump to the mark, the point moves to the last visible, usually
folded headline of the file, even if I had not edited it recently, and I
have always assumed that it's because it wants to go to the end of the
buffer for some reason I've never been able to come up with or
debug. Could that have something to do with this?
Best regards,
Ignacio
Emacs : GNU Emacs 29.0.50 (build 53, x86_64-pc-linux-gnu, GTK+ Version
3.24.20, cairo version 1.16.0)
of 2022-05-22
Package: Org mode version 9.5.3 (release_9.5.3-6-gef41f3 @
/home/ignacio/repos/emacs/lisp/org/)
