On 26/04/2022 02:49, Paul Eggert wrote:
On 4/25/22 08:37, Paul Eggert wrote:
I'll be happy to review the revised org-encode-time implementation,
whenever you think it could use a review. (Sorry, I've lost track of
what the proposal is.)
I suspended my activity due to discussions of other changes and waiting
for commits related to your fixes of `org-parse-time-string' and
`org-store-link' that do not require introducing of `org-encode-time-1'.
I mean excerpts from
https://debbugs.gnu.org/cgi/bugreport.cgi?att=1;msg=10;bug=54764;filename=0001-Improve-Org-usage-of-timestamps.patch
I posted a corrected version of my `org-encode-time' macro, but I did
not add you to Cc (I sent reply through news.gmane.io), and it has no
special case to check whether `encode-time' supports 6 elements list
argument:
Max Nikulin to emacs-orgmode. [DRAFT][PATCH v2] org-encode-time
compatibility and convenience helper. Sun, 24 Apr 2022 18:34:40 +0700.
https://list.orgmode.org/t43cki$ct$1...@ciao.gmane.io
In my drafts I have the following changes in tests related to
`org-parse-time-string':
diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el
index 6aecc3af8..551d17d64 100644
--- a/testing/lisp/test-org.el
+++ b/testing/lisp/test-org.el
@@ -268,15 +268,15 @@
(ert-deftest test-org/org-parse-time-string ()
"Test `org-parse-time-string'."
(should (equal (org-parse-time-string "2012-03-29 16:40")
- '(0 40 16 29 3 2012 nil nil nil)))
+ '(0 40 16 29 3 2012 nil -1 nil)))
(should (equal (org-parse-time-string "[2012-03-29 16:40]")
- '(0 40 16 29 3 2012 nil nil nil)))
+ '(0 40 16 29 3 2012 nil -1 nil)))
(should (equal (org-parse-time-string "<2012-03-29 16:40>")
- '(0 40 16 29 3 2012 nil nil nil)))
+ '(0 40 16 29 3 2012 nil -1 nil)))
(should (equal (org-parse-time-string "<2012-03-29>")
- '(0 0 0 29 3 2012 nil nil nil)))
+ '(0 0 0 29 3 2012 nil -1 nil)))
(should (equal (org-parse-time-string "<2012-03-29>" t)
- '(0 nil nil 29 3 2012 nil nil nil))))
+ '(0 nil nil 29 3 2012 nil -1 nil))))
(ert-deftest test-org/closest-date ()
"Test `org-closest-date' specifications."
