Hi Nicolas, Thank you for the reviewing my suggestions. I've fixed issues you've listed. I've attached new patch to this email.
Let me know what you think. Thanks, Mikhail On Sun, 2021-12-26 at 22:26 +0100, Nicolas Goaziou wrote: > Hello, > > Thanks. Some comments follow. > > Mikhail Skorzhinskii <mskorzhins...@eml.cc> writes: > > > * lisp/ox-icalendar.el (org-icalendar-scheduled-summary-prepend): > > configurable prefix for the scheduled headlines > > "New variable" is enough. > > > * lisp/ox-icalendar.el (org-icalendar-deadline-summary-prepend): > > configurable prefix for the headlines with a deadline > > Ditto. > > > +(defcustom org-icalendar-scheduled-summary-prepend "S: " > > + "String used for prepending summary in exported scheduled > > headlines." > > + :group 'org-export-icalendar > > + :type 'string) > > + > > + > > +(defcustom org-icalendar-deadline-summary-prepend "DL: " > > + "String used for prepending summary in exported deadlines." > > + :group 'org-export-icalendar > > + :type 'string) > > + > > Could you add missing :safe and :package-version keywords? > > Regards,
From 6849f0dde1cc8fefbfea0271039e5066a3cb2746 Mon Sep 17 00:00:00 2001 From: Mikhail Skorzhinskii <mskorzhins...@eml.cc> Date: Sat, 12 Sep 2020 18:27:23 +0200 Subject: [PATCH 3/5] ox-icalendar.el: customizable vevent summary prefix * lisp/ox-icalendar.el (org-icalendar-scheduled-summary-prepend): new variable * lisp/ox-icalendar.el (org-icalendar-deadline-summary-prepend): new variable * lisp/ox-icalendar.el (org-icalendar-entry): use a configurable headline prefixes (see above) instead of hardcoded ones --- lisp/ox-icalendar.el | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/lisp/ox-icalendar.el b/lisp/ox-icalendar.el index 68c5679ea..189e35946 100644 --- a/lisp/ox-icalendar.el +++ b/lisp/ox-icalendar.el @@ -84,6 +84,21 @@ keyword." :group 'org-export-icalendar :type '(repeat (string :tag "Tag"))) +(defcustom org-icalendar-scheduled-summary-prepend "S: " + "String used for prepending summary in exported scheduled headlines." + :group 'org-export-icalendar + :type 'string + :package-version '(Org . "9.6") + :safe #'stringp) + + +(defcustom org-icalendar-deadline-summary-prepend "DL: " + "String used for prepending summary in exported deadlines." + :group 'org-export-icalendar + :type 'string + :package-version '(Org . "9.6") + :safe #'stringp) + (defcustom org-icalendar-use-deadline '(event-if-not-todo todo-due) "Contexts where iCalendar export should use a deadline time stamp. @@ -607,7 +622,7 @@ inlinetask within the section." (_ (memq 'event-if-not-todo use-deadline))) (org-icalendar--vevent entry deadline (concat "DL-" uid) - (concat "DL: " summary) loc desc cat tz class))) + (concat org-icalendar-deadline-summary-prepend summary) loc desc cat tz class))) (let ((scheduled (org-element-property :scheduled entry)) (use-scheduled (plist-get info :icalendar-use-scheduled))) (and scheduled @@ -618,7 +633,7 @@ inlinetask within the section." (_ (memq 'event-if-not-todo use-scheduled))) (org-icalendar--vevent entry scheduled (concat "SC-" uid) - (concat "S: " summary) loc desc cat tz class))) + (concat org-icalendar-scheduled-summary-prepend summary) loc desc cat tz class))) ;; When collecting plain timestamps from a headline and its ;; title, skip inlinetasks since collection will happen once ;; ENTRY is one of them. -- 2.32.0
