>From 7dc855ae1d7992eaacc2cab13a39c6000e4e66bf Mon Sep 17 00:00:00 2001 Message-Id: <7dc855ae1d7992eaacc2cab13a39c6000e4e66bf.1622468529.git.yanta...@gmail.com> From: Ihor Radchenko <yanta...@gmail.com> Date: Mon, 31 May 2021 21:39:51 +0800 Subject: [PATCH] Correctly handle org-log-note-clock-out non-interactively
* org-clock.el (org-clock-out): Delay log popup to after-command-hook to avoid messing up non-interactive calls. `org-add-log-setup' without 'note argument would raise interactive note buffer immediately, so we do pass the 'note argument. --- org-clock.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org-clock.el b/org-clock.el index 3b7d97639..0328bddd3 100644 --- a/org-clock.el +++ b/org-clock.el @@ -1691,7 +1691,7 @@ (defun org-clock-out (&optional switch-to-state fail-quietly at-time) (line-beginning-position 2))) (org-log-note-clock-out (org-add-log-setup - 'clock-out nil nil nil + 'clock-out nil nil 'note (concat "# Task: " (org-get-heading t) "\n\n")))) (when org-clock-mode-line-timer (cancel-timer org-clock-mode-line-timer) -- 2.26.3
Hello everyone! The manual says: ‘S-<UP>’ (‘org-timestamp-up’) ‘S-<DOWN>’ (‘org-timestamp-down’) On the beginning or enclosing bracket of a timestamp, change its type. Within a timestamp, change the item under point. Point can be on a year, month, day, hour or minute. When the timestamp contains a time range like ‘15:30-16:30’, modifying the first time also shifts the second, shifting the time block with constant length. [...] However, on the timestamp [2021-08-21 sáb 10:00-12:00], with point right after the first colon, typing C-u 42 S-<up> results in [2021-08-21 sáb 10:42-12:05]. The problem also occurs with S-<down>. This occurs on GNU Emacs 28.0.50 installed with ~guix package --with-branch=emacs-next=master -i emacs-next~ (upgraded last Thursday morning), invoked as ~emacs -q~. Note that on my Guix-installed Emacs, an ~emacs -q~ does load the emacs-org Guix package (version 9.4.6). Note also that my Org Mode has been patched with Ihor Radchenko's patch to org-clock.el (attached), but it clearly can't influence this problem. Regards Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) Package: Org mode version 9.4.6 (9.4.6-gab9f2a @ /gnu/store/yg6kjzigqyfzbkzj99xmwmv3nssvhvnq-emacs-org-9.4.6/share/emacs/site-lisp/org-9.4.6/) -- - Disinformation flourishes because many people care about injustice but very few check the facts. Ask me about <https://stallmansupport.org> - I am Brazilian. I hope my English is correct and I welcome feedback. - Free Software Supporter: https://www.fsf.org/free-software-supporter - If an email of mine arrives at your spam box, please notify me.