Hello,
Sorry for the delayed reply. On Sunday, 27 Jun 2021 at 10:12, Jack Kamm wrote: @Colin, thanks for your feedback. I have to confess that I didn't know about the second file parameter at all until I provided the patch. I just discovered main branch works with the second :file specification, by chance just before your mail. I have been led into the wrong direction trying to get back the old specification for graphics link. #+BEGIN_SRC R :results output graphics :file test.pdf plot(1) #+end_src The documentation about this part is poor and I must have missed these dicussions on the mailing list. So all this time I lived without the graphics link. ;-|. Now that I am back on track, I will check how well the current version works particularly for remote connection. If it does the patch will be redundant. > However, I tested Jeremie's example on latest org master and it also > worked fine for me, also on remote sessions. @Jack thanks for your feedback. I'll improve my style. > > The requirement for a second file parameter was added in Org 9.3 to > support the use case in this thread: > > https://orgmode.org/list/3ac2f42a-8ff2-1464-fa36-451e2ef0e...@pressure.to/ > > But this syntax is annoyingly verbose for ob-R users, and also broke > lots of ob-R examples prior to Org 9.3. > > A simple fix might be to have the "graphics" flag implicitly add the > "file" flag as well. But we would need to first check that this doesn't > break other use cases. I do agree with this solution. If the current specification works, we could make it easy for ob-R user by implicitly adding a file flag. But as far as I understand, the change will have to be made in ob-core.el. > >> Subject: [PATCH 1/4] ob-R.el: Remove redundant argument to function > > I think it would be better to squash these changes into a single commit. > Thanks again for the feedback. Best regards, -- Jeremie Juste
