On 2021-06-05, 19:40 +0700, Maxim Nikulin <maniku...@gmail.com> wrote:
> This line should be added to org-table.el, but notice "rx ‘not’ syntax > error: (or ". This logical operators have a bit different meaning for > regular expression. > > Nicolas suggested you to use `list' to avoid `eval'. Certainly `eval' > should be avoided whenever possible, but there is alternative with "`" > and "," instead of "'". Though I often prefer `list'. Done. >> Can you also share test.org so that I can test locally? > > I can reproduce it with an empty org file. Emacs-26.3. So I am curious > if your tested your patch at all. Yes you are right I was not testing my patches using 'emacs -Q' and I am apologetic about it. I just "tested" most of them by M-x eval-buffer on the patched file and then checked the output of `with-temp-buffer'. >> Now on the topic of CSV parser, I have succesfully implemented a CSV >> parser in less than 65 LOC which also preserves newline character but I >> am facing a dilemma on how should I represent it as a Org table. For >> ex: > ... >> 6,"Cell with new >> Line",6.28 > > Due to > https://orgmode.org/worg/org-faq.html#Tables > "Will there ever be support for multiple lines in a table field? No." > (there are may be some tricks in Org manual) any variant is acceptable, > even current one. Since during export split cell is considered as > different rows, it is responsibility of the user to preprocess original > file and import it in a form suitable for Org. > > However independently of chosen variant, it would be great to get list > of warnings with ambiguous lines similar to compiler errors. Such > feature is not implemented in Org yet, the most close is `org-lint' > result (its behavior differs from compiler errors). After reading FAQ about multiple lines in table field I don't think this PATCH makes much sense as my main driving force for this patch was to simplify regular expression in `org-table-convert-region' and somehow add newlines support. I also think `org-table-convert-region' is doing a fine job and I should keep my "I want to contribute...." habit in check. > I expect complexity O(number of lines in result). I do not like > excessive usage of `dolist'. I would try slicing subrows using `mapcar' > while there is at least one non-nil element. Yes! Currently I am trying to sequentially read Elisp manual and I have completed the section on 'Mapping Function' yesterday. I think it's a really nice language feature that I can make use of. > P.S. Have you read "Structure and Interpretation of Computer Programs" > by Abelson, Sussman, and Sussman? > https://sarabander.github.io/sicp/html/index.xhtml > or https://mitpress.mit.edu/sites/default/files/sicp/index.html > While reading, it is necessary to realize that elisp is not scheme, tail > recursion should be avoided in elisp and there are over differences. Thank you! I have seen most of the decision on Lisp includes SICP but I am currently stopping myself to Elisp manual to learn something useful about this timeless editor and learn thing in a step-by-step manner. I also tried Racket after reading: https://dustycloud.org/blog/racket-is-an-acceptable-python https://beautifulracket.com/ But stopped myself for the reason same as above. -- Utkarsh Singh http://utkarshsingh.xyz
