On 2021-02-12, Kyle Meyer wrote: > TEC writes: > >> Hi All, >> >> This is just some tweaks to the styling in ox-html that I think may >> appeal (and prevent ridiculously long lines on non-small displays, which >> are an issue for legibility). >> >> I also took the opportunity to remove the (obsolete) CDATA strings and >> make the CSS more consistently formatted. If you don't want this to >> get its own commit, please just squash it. >> >> Style changes: >> - Restrict max content width, and centre >> - tweak styling of source code blocks > > I'm sure there are plenty of opinionated ox-html users on the list. Is > anyone willing to provide feedback on this series? Please don't assume > you need commit access to provide reviews.
Hi there, I do not know why the CDATA lines exist. I don’t see a reason to keep them (patch 0001), but that might be a lack of understanding on my part. Patch 0003 is about whitespace fixes. Patches 0002, 0004, 0005 change defconst styling. I don’t have a strong opinion here. However, if they are changed now, what about turning them into defcustoms? Then each of us would be entitled to their own opinion ;) The docstring for org-html-head-include-default-style says that org-html-style-default (a defconst proposed to be changed here) should not be changed. Why not? Best wishes Jens
smime.p7s
Description: S/MIME cryptographic signature
