> thanks for the patch. I assume you are submitting it against master, > am I right?
The patch is against commit 2e96dc639. > From reading this, I don't see what bug it fixes, what problem it > solves or what real user need it responds to, but maybe I lost part > of the context. Can you explain why this should be applied? It does not fix any bug. Rather adds a new feature [1]. Currently, org provides org-link-make-description-function as user customisation to compute default link description. The patch provides a way to set such description functions on per link type basis (via :description link parameter). Using link parameters looks natural for me since similar customisation is already done in :follow and :store link parameters. [1] https://lists.gnu.org/archive/html/emacs-orgmode/2019-08/msg00013.html Best, Ihor Bastien <b...@gnu.org> writes: > Hi Ihor, > > thanks for the patch. I assume you are submitting it against master, > am I right? > > Ihor Radchenko <yanta...@gmail.com> writes: > >> +`:description' >> + >> + Function to use for generating link descriptions from links. This >> + function must take two parameters: the first one is the link, the >> + second one is the description generated by `org-insert-link'. The >> + function should return the description to use. > > From reading this, I don't see what bug it fixes, what problem it > solves or what real user need it responds to, but maybe I lost part > of the context. Can you explain why this should be applied? > > Thanks, > > -- > Bastien -- Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China Email: yanta...@gmail.com, ihor_radche...@alumni.sutd.edu.sg
