Nicolas Goaziou <m...@nicolasgoaziou.fr> writes:
> Hello,
>
> stardiviner <numbch...@gmail.com> writes:
>
>> Aha, Thanks, Nicolas, I almost forget this patch. That's great!
>
> Speaking of which, there's an issue in
> `org-babel-eshell-initiate-session'.
>
> First, it uses (get-buffer (current-buffer)), which is equivalent to
> (current-buffer). But, more importantly, it doesn't do anything with it?
> So what is the point of the `progn' in that function?
You're right.
It originally suppose to return the Eshell session buffer (return value) to be
used by other functions. But at last function
`org-babel-eshell-initiate-session` seems still return `session`. So this
`(get-buffer (current-buffer))` seems not necessary.
Can you remove it? Regenerate patches on my side is little kind of trouble.
>
> Regards,
--
[ stardiviner ] don't need to convince with trends.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
