Hello,

Eric S Fraga <esfli...@gmail.com> writes:

> I've compared timings old with new (from git a few minutes ago) by
> starting up emacs, instrumenting package org, viewing agenda (defaults
> to 1 day), switching to month view and then moving to the following
> month:
>
> Old agenda:
>
> | org-agenda-list               |     3 | 19.770361111 | 6.5901203703 |

[...]

> New agenda:
>
> | org-agenda-list               |      3 | 29.473988928 |  9.824662976 |

How great! I managed to achieve a negative speed up.

> | org-agenda-skip               |  97251 | 8.0815792529 | 8.310...e-05 |

I overlooked `org-agenda-skip', which does nothing fancy on my side. It
is indeed called more often...

Skipping is actually harder with the cache, because you want to cache
everything anyway (or the cache cannot be trusted).

> I had to remove a bunch of <%% (...)> items in one of my agenda files as
> these gave me error messages about the sexp.

Could you show one of the culprits?

> Finally, most importantly, the actual items shown in the day view with
> the new code are only a subset of those shown with the old view.  I
> cannot see any pattern in those omitted.

There may be more than one pattern involved. Maybe the types involved
would help.

I updated the "wip-agenda-speedup" branch (rebasing needed). It should
now call `org-agenda-skip' less often. Could you try again using that?

Thank you for the feedback.

Regards,

-- 
Nicolas Goaziou

Reply via email to