Hello, Justin Kirby <justinki...@gmail.com> writes:
> I added a port switch for postgresql in ob-sql.el Thank you for the patch. Some comments follow. > I have attached a simple patch to fix this and have verified it works > for me. I would have loved to add some tests, but I ran into some > problems: > > 1) I could not figure out how to get just one test file to run > 2) I was not able get make test to load the sql language in babel > > > Is there a recommended/standard way to resolve these problems with > tests? See <http://orgmode.org/worg/dev/org-build-system.html>, in particular BTEST_RE and BTEST_OB_LANGUAGES environment variables. > From 4ca513afe3725fbfbefd7ad9bf54637adfd56ea2 Mon Sep 17 00:00:00 2001 > From: Justin Kirby <jus...@redsorbet.com> > Date: Wed, 18 May 2016 23:14:48 -0400 > Subject: [PATCH] add dbport parameter to postgresql dbstring First letter should be upper case. You also need to provide the name of the function being modified in the commit message, e.g. lisp/ob-sql.el (org-babel-sql-dbstring-postgresql): Add PORT argument. (org-babel-execute:sql): Apply previous change. I you haven't signed FSF papers, you also need to add TINYCHANGE at the end of the commit message. Could you send an updated patch ? Also, could you provide a short notice in ORG-NEWS (located in doc/)? Regards, -- Nicolas Goaziou
