Hello, Joost Helberg <jo...@snow.nl> writes:
> this patch adds the list of figures to the html export backend. It also > includes a translation entry-point for the label "List of Figures" with > already one translation in: dutch. Thank you. > From fab9105d04e5cb9f923c17d322d84a25527ec27a Mon Sep 17 00:00:00 2001 > From: Joost Helberg <jo...@snow.nl> > Date: Sun, 8 Nov 2015 14:34:11 +0100 > Subject: [PATCH] ox-html.el: added list of figures support in html > backend It should be ox-html: Add list of figures > * lisp/ox-html.el (org-html-list-of-figures): new, similar to > org-html-list-of-tables but with tables replaced by figures. This is, indeed, almost the same as `org-html-list-of-tables' and `org-html-list-of-listings'. I suggest to refactor the 3 functions to use a generic one. Also please use a recent version of `org-html-list-of-tables' since yours contain deprecated code (e.g., `org-export-solidify-link-text'). > (org-html-list-of-tables): added mapping keyword "figures" > to new function org-html-list-of-figures. You can remove this. > ox.el: added label for "list of figures" Ditto. > * lisp/ox.el (org-export-dictionary): Added label for List of > Figures with dutch translation You need to add TINYCHANGE at the end of the commit message, if you haven't signed FSF papers yet. > +(defun org-html-list-of-figures (info) > + "Build a list of figures. > +INFO is a plist used as a communication channel. Return the list > +of figures as a string, or nil if it is empty." > + (let ((lol-entries (org-export-collect-figures info nil))) (org-export-collect-figures info nil) is rather sloppy. It collects all paragraphs with a caption. Is it a proper definition for "figures"? Regards, -- Nicolas Goaziou
