branch: externals/substitute commit a1afb50cea273514ab6655b136fe11973d35af96 Author: Protesilaos Stavrou <i...@protesilaos.com> Commit: Protesilaos Stavrou <i...@protesilaos.com>
Use the underscore when let binding for side effects only I like this style more because it is more clear what is happening. --- substitute.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/substitute.el b/substitute.el index 8fbebef88c..e086792bce 100644 --- a/substitute.el +++ b/substitute.el @@ -79,7 +79,7 @@ For a reference function, see `substitute-report-operation'." (defface substitute-match `((t :inherit ,(if-let* ((face 'lazy-highlight) - ((facep face))) + (_ (facep face))) face 'secondary-selection))) "Face to highlight matches of the given target." @@ -159,7 +159,7 @@ Pass to it the TARGET and SCOPE arguments." (defun substitute--scope-current-and-below (target) "Position point to match current TARGET and below." (widen) - (if-let* (((region-active-p)) + (if-let* ((_ (region-active-p)) (bounds (region-bounds))) (goto-char (caar bounds)) (thing-at-point-looking-at target) @@ -168,7 +168,7 @@ Pass to it the TARGET and SCOPE arguments." (defun substitute--scope-current-and-above (target) "Position point to match current TARGET and above." (widen) - (if-let* (((region-active-p)) + (if-let* ((_ (region-active-p)) (bounds (region-bounds))) (goto-char (cdar bounds)) (thing-at-point-looking-at target)