branch: externals/emms
commit 419e1bd71d4e65ea53f4eda55867b8b1dea3835c
Author: Erica Lina <erical...@proton.me>
Commit: Erica Lina <erical...@proton.me>
Turn filter definitions into defvars to fix unbound symbol warning.
---
emms-filters.el | 113 +++++++++++++++++++++++++++++---------------------------
1 file changed, 59 insertions(+), 54 deletions(-)
diff --git a/emms-filters.el b/emms-filters.el
index d5224adbb7..b8250072df 100644
--- a/emms-filters.el
+++ b/emms-filters.el
@@ -1238,60 +1238,65 @@ Returns True if the track should be filtered out."
(emms-filters-register-filter "No filter" nil)
;; factory name factory arg
-(setq emms-filters-decade-filters
- '(("Year range" "1900s" 1900 1909)
- ("Year range" "1910s" 1910 1919)
- ("Year range" "1920s" 1920 1929)
- ("Year range" "1930s" 1930 1939)
- ("Year range" "1940s" 1940 1949)
- ("Year range" "1950s" 1950 1959)
- ("Year range" "1960s" 1960 1969)
- ("Year range" "1970s" 1970 1979)
- ("Year range" "1980s" 1980 1989)
- ("Year range" "1990s" 1990 1999)
- ("Year range" "2000s" 2000 2009)
- ("Year range" "2010s" 2010 2019)
- ("Year range" "2020s" 2020 2029)))
-
-(setq emms-filters-genre-filters
- '(("Genre" "Waltz" "waltz")
- ("Genre" "Vals" "vals")
- ("Genre" "Tango" "tango")
- ("Genre" "Milonga" "milonga")
- ("Genre" "Condombe" "condombe")
- ("Genre" "Salsa" "salsa")
- ("Genre" "Blues" "blues")
- ("Genre" "Rock" "rock")
- ("Genre" "Swing" "swing")
- ("Genre" "Pop" "pop")
- ("Genre" "Rap" "rap")
- ("Genre" "Hip hop" "hip hop")
- ("Genre" "Classical" "classical")
- ("Genre" "Baroque" "baroque")
- ("Genre" "Chamber" "chamber")
- ("Genre" "Reggae" "reggae")
- ("Genre" "Folk" "folk")
- ("Genre" "World" "world")
- ("Genre" "Metal" "metal")
- ("Genre" "Fusion" "fusion")
- ("Genre" "Jazz" "jazz")))
-
-(setq emms-filters-last-played-filters
- '(("Played since" "Played in the last month" 30)
- ("Not played since" "Not played since a year" 365)))
-
-(setq emms-filters-track-type-filters
- '(("Track type" "File" file)
- ("Track type" "Url" url)
- ("Track type" "Stream" stream)
- ("Track type" "Stream list" streamlist)
- ("Track type" "Play list" playlist)))
-
-(setq emms-filters-duration-filters
- '(("Duration less" "Duration <1 min" 60)
- ("Duration less" "Duration <5 min" 300)
- ("Duration more" "Duration >5 min" 300)
- ("Duration more" "Duration >10 min" 600)))
+(defvar emms-filters-decade-filters
+ '(("Year range" "1900s" 1900 1909)
+ ("Year range" "1910s" 1910 1919)
+ ("Year range" "1920s" 1920 1929)
+ ("Year range" "1930s" 1930 1939)
+ ("Year range" "1940s" 1940 1949)
+ ("Year range" "1950s" 1950 1959)
+ ("Year range" "1960s" 1960 1969)
+ ("Year range" "1970s" 1970 1979)
+ ("Year range" "1980s" 1980 1989)
+ ("Year range" "1990s" 1990 1999)
+ ("Year range" "2000s" 2000 2009)
+ ("Year range" "2010s" 2010 2019)
+ ("Year range" "2020s" 2020 2029))
+ "filter tracks by decade")
+
+(defvar emms-filters-genre-filters
+ '(("Genre" "Waltz" "waltz")
+ ("Genre" "Vals" "vals")
+ ("Genre" "Tango" "tango")
+ ("Genre" "Milonga" "milonga")
+ ("Genre" "Condombe" "condombe")
+ ("Genre" "Salsa" "salsa")
+ ("Genre" "Blues" "blues")
+ ("Genre" "Rock" "rock")
+ ("Genre" "Swing" "swing")
+ ("Genre" "Pop" "pop")
+ ("Genre" "Rap" "rap")
+ ("Genre" "Hip hop" "hip hop")
+ ("Genre" "Classical" "classical")
+ ("Genre" "Baroque" "baroque")
+ ("Genre" "Chamber" "chamber")
+ ("Genre" "Reggae" "reggae")
+ ("Genre" "Folk" "folk")
+ ("Genre" "World" "world")
+ ("Genre" "Metal" "metal")
+ ("Genre" "Fusion" "fusion")
+ ("Genre" "Jazz" "jazz"))
+ "Some filters for a the track genre")
+
+(defvar emms-filters-last-played-filters
+ '(("Played since" "Played in the last month" 30)
+ ("Not played since" "Not played since a year" 365))
+ "filters for the last time a track was played")
+
+(defvar emms-filters-track-type-filters
+ '(("Track type" "File" file)
+ ("Track type" "Url" url)
+ ("Track type" "Stream" stream)
+ ("Track type" "Stream list" streamlist)
+ ("Track type" "Play list" playlist))
+ "filters for track types")
+
+(defvar emms-filters-duration-filters
+ '(("Duration less" "Duration <1 min" 60)
+ ("Duration less" "Duration <5 min" 300)
+ ("Duration more" "Duration >5 min" 300)
+ ("Duration more" "Duration >10 min" 600))
+ "filters for the duration of a track.")
(defun emms-filters-make-default-filters()
"Make some default filters anyone would not mind having."
