I see your point. Map.take/2 might be misused as well, should this note be
added to Map.take or Map.take! (or both)?

Additional question: if we are adding drop!/2, we should probably use
delete!/2 as well (note: pop!/2 already exists), what do you think?


Le lun. 25 oct. 2021 à 22:28, José Valim <[email protected]> a écrit :

> One thing to note though is that pattern matching is going to be the most
> efficient in most cases, if you want the actual values. So the docs need to
> be clearer that this is to return a new map with said keys.
>
> On Mon, Oct 25, 2021 at 3:11 PM José Valim <[email protected]> wrote:
>
>> Sounds good to me, but we will also need Map.drop! for consistency?
>>
> --
> You received this message because you are subscribed to the Google Groups
> "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4J7%2Brq8nTq7sU2XqAZ55gSnVFJq2LBey32tpMAVwx0eNw%40mail.gmail.com
> <https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4J7%2Brq8nTq7sU2XqAZ55gSnVFJq2LBey32tpMAVwx0eNw%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/CANnyohYu1SdTQU1M3YFQ9rYBdB-B9ZKbH6iuNr425mSPHBufcw%40mail.gmail.com.

Reply via email to