On Mon, Mar 3, 2025 at 10:02 PM Frank Ch. Eigler <f...@redhat.com> wrote: > > Hi - > > Thanks for the review! > > > On my machine memcheck reports leaks due to target_cachehdr_path > > missing a free. [...] > > Sorry! I must have sent an immediately prior version of the patch; > the following one has the missing free(). > > > [...] > > There is some stray white space at the end of this line and elsewhere. > > Hehehe, okay, nuked that. > > > [...] > > It doesn't have to be done in this patch but we could add a read_retry > > function to elfutils lib/system.h to handle reading all bytes. There > > are some read calls in debuginfod.cxx where read_retry could also be used. > > Just switched to using pread_retry() already there, and pwrite_retry() > for the corresponding other case. > > v2 patch:
Thanks Frank, LGTM. Aaron
